Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trusted AI pipeline to have unique job names #760

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

Tomcli
Copy link
Member

@Tomcli Tomcli commented Oct 25, 2021

Which issue is resolved by this Pull Request:
Resolves #

Description of your changes:
Update trusted AI pipeline to have unique job names so it can run multiple times without cleaning up the jobs.

Environment tested:

  • Python Version (use python --version):
  • Tekton Version (use tkn version):
  • Kubernetes Version (use kubectl version):
  • OS (e.g. from /etc/os-release):

Checklist:

@Tomcli
Copy link
Member Author

Tomcli commented Oct 25, 2021

This can work on both Argo and Tekton runtime because we have workflow name substitution in KFP-TEKTON

Copy link
Contributor

@ScrapCodes ScrapCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Do you think, all these variables are already documented?

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ScrapCodes, Tomcli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 99d28bb into master Oct 26, 2021
@Tomcli Tomcli deleted the Tomcli-patch-3 branch January 6, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants