Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable strip eof and archive logs as default #747

Merged
merged 1 commit into from
Oct 9, 2021

Conversation

Tomcli
Copy link
Member

@Tomcli Tomcli commented Oct 8, 2021

Which issue is resolved by this Pull Request:
Resolves #

Description of your changes:
The strip eof and archive logs features have been used internally and during demos for the past few months. It's proven that it didn't cost too much bottleneck during regular usage, so we are now promoting these features as default to align with the latest kfp settings.

Environment tested:

  • Python Version (use python --version):
  • Tekton Version (use tkn version):
  • Kubernetes Version (use kubectl version):
  • OS (e.g. from /etc/os-release):

Checklist:

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Tomcli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pugangxa
Copy link
Contributor

pugangxa commented Oct 9, 2021

/lgtm

@google-oss-robot google-oss-robot merged commit eb44737 into kubeflow:master Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants