Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk) orig_params being overwritten in custom-tasks #742

Conversation

Udiknedormin
Copy link
Contributor

Which issue is resolved by this Pull Request:
In some rare cases (difficult to reproduce), pipeline params in custom tasks are not recognised as orig_params and therefore $(inputs.params.foo-bar) is produced instead of $(params.foo-bar).

Description of your changes:
When custom task spec is overwritten from its taskSpec, all fields were pasted as-is. However, one of those was "orig_params": task_ref["params"] --- which works differently the first and the second time it's called, thus dropping the actual information on original parameters.

This PR factors out that variable and pastes it in both places without dropping its previous value.

Environment tested:

  • Python Version (use python --version): 3.9.0
  • Tekton Version (use tkn version): irrelevant
  • Kubernetes Version (use kubectl version): irrelevant
  • OS (e.g. from /etc/os-release): irrelevant

Checklist:

Copy link
Member

@Tomcli Tomcli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Tomcli, Udiknedormin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit d15acfd into kubeflow:master Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants