fix(sdk) orig_params being overwritten in custom-tasks #742
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
In some rare cases (difficult to reproduce), pipeline params in custom tasks are not recognised as
orig_params
and therefore$(inputs.params.foo-bar)
is produced instead of$(params.foo-bar)
.Description of your changes:
When custom task spec is overwritten from its
taskSpec
, all fields were pasted as-is. However, one of those was"orig_params": task_ref["params"]
--- which works differently the first and the second time it's called, thus dropping the actual information on original parameters.This PR factors out that variable and pastes it in both places without dropping its previous value.
Environment tested:
python --version
): 3.9.0tkn version
): irrelevantkubectl version
): irrelevant/etc/os-release
): irrelevantChecklist: