Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pipelineloop): Update pipelineloop v2 to have failed and cancelled status #1445

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

Tomcli
Copy link
Member

@Tomcli Tomcli commented Jan 4, 2024

Which issue is resolved by this Pull Request:
Resolves #

Description of your changes:

Environment tested:

  • Python Version (use python --version):
  • Tekton Version (use tkn version):
  • Kubernetes Version (use kubectl version):
  • OS (e.g. from /etc/os-release):

Checklist:

@Tomcli
Copy link
Member Author

Tomcli commented Jan 5, 2024

/assign @yhwang
This PR will add the fail status to the pipelineloop customrun when it failed/cancelled. Previously we only update failing states for each iteration pipelinerun dag.

The next phase for this is to merge the pipelineloop driver/publisher tasks into the controller itself. The previous PR only merge for each iteration dag but not the main pipelineloop object dag.

Copy link
Member

@yhwang yhwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jan 5, 2024
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Tomcli, yhwang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit a71ba16 into kubeflow:master Jan 5, 2024
15 of 16 checks passed
@Tomcli Tomcli deleted the pipelineloop-fail-status branch January 5, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants