Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tekton-catalog): Move v2 tekton-exithandler custom task to tekton catalog #1370

Merged
merged 3 commits into from
Oct 11, 2023
Merged

feat(tekton-catalog): Move v2 tekton-exithandler custom task to tekton catalog #1370

merged 3 commits into from
Oct 11, 2023

Conversation

Tomcli
Copy link
Member

@Tomcli Tomcli commented Oct 10, 2023 •
edited
Loading

Which issue is resolved by this Pull Request:
Part of #1364

Description of your changes:

Environment tested:

  • Python Version (use python --version):
  • Tekton Version (use tkn version):
  • Kubernetes Version (use kubectl version):
  • OS (e.g. from /etc/os-release):

Checklist:

@Tomcli
Copy link
Member Author

Tomcli commented Oct 10, 2023 •
edited
Loading

/assign @yhwang

1 similar comment
@Tomcli
Copy link
Member Author

Tomcli commented Oct 10, 2023

/assign @yhwang

yhwang
yhwang approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@yhwang yhwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Oct 11, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Tomcli, yhwang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit f94859a into kubeflow:master Oct 11, 2023
16 checks passed
@Tomcli Tomcli deleted the kfp-exithandler branch October 11, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhwang yhwang yhwang approved these changes

@fenglixa fenglixa Awaiting requested review from fenglixa

@jinchihe jinchihe Awaiting requested review from jinchihe

Assignees

@yhwang yhwang

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tomcli @yhwang