Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): update toolchain image/script #1189

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

yhwang
Copy link
Member

@yhwang yhwang commented Mar 16, 2023

Description of your changes:
update the toolchain image and update the script to be able to specify the URL of the public container registry

Checklist:

@yhwang
Copy link
Member Author

yhwang commented Mar 16, 2023

I am waiting for the results of the toolchain. update the result later

update the toolchain image and update the script to
be able to specify the url of public container registry
and scripts

Signed-off-by: Yihong Wang <[email protected]>
@yhwang
Copy link
Member Author

yhwang commented Mar 16, 2023

the toolchain passed!

@yhwang yhwang requested a review from Tomcli March 16, 2023 15:45
Copy link
Member

@Tomcli Tomcli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Tomcli, yhwang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 7414106 into kubeflow:master Mar 16, 2023
@yhwang yhwang deleted the update-toolchain-images branch March 16, 2023 16:31
Tomcli pushed a commit to Tomcli/kfp-tekton that referenced this pull request Mar 17, 2023
update the toolchain image and update the script to
be able to specify the url of public container registry
and scripts

Signed-off-by: Yihong Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants