Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(manifests): Fix broken github link #1147

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

Tomcli
Copy link
Member

@Tomcli Tomcli commented Feb 7, 2023

Which issue is resolved by this Pull Request:
Resolves #

Description of your changes:
Tekton Dashboard yamls are no longer hosted on Github. Instead they all hosted on GCS.

Environment tested:

  • Python Version (use python --version):
  • Tekton Version (use tkn version):
  • Kubernetes Version (use kubectl version):
  • OS (e.g. from /etc/os-release):

Checklist:

@Tomcli
Copy link
Member Author

Tomcli commented Feb 7, 2023

/assign @yhwang

Copy link
Member

@yhwang yhwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Feb 7, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Tomcli, yhwang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yhwang
Copy link
Member

yhwang commented Feb 7, 2023

@Tomcli don't we have the readme link checker?

@google-oss-prow google-oss-prow bot merged commit ea5821f into kubeflow:master Feb 7, 2023
@Tomcli
Copy link
Member Author

Tomcli commented Feb 7, 2023

@Tomcli don't we have the readme link checker?

The readme link checker doesn't check embedded links in code block. Also some code block just have placeholder links so we probably need to make the link checker opt out certain files if we want to update it to also check for code block links.

@Tomcli Tomcli deleted the fix-link branch February 7, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants