Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk) include finally tasks in placeholder indir #1035

Conversation

Udiknedormin
Copy link
Contributor

Which issue is resolved by this Pull Request:
Resolves #1034.

Description of your changes:
Include finally tasks in _handle_tekton_pipeline_variables.

Environment tested:

  • Python Version (use python --version): 3.9.0
  • Tekton Version (use tkn version): 8bcb27213e1a6a0b75e133f2acb60e9be51827e5
  • Kubernetes Version (use kubectl version): 0.36.0
  • OS (e.g. from /etc/os-release): irrelevant

Checklist:

@Tomcli
Copy link
Member

Tomcli commented Aug 23, 2022

Thanks @Udiknedormin
I will follow up with the test cases PR in your issue to make sure this code won't break in the future.

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Tomcli, Udiknedormin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 2900f9e into kubeflow:master Aug 23, 2022
google-oss-prow bot pushed a commit that referenced this pull request Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(sdk) Any-sequencer in "finally" generates failing yaml
2 participants