Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): Add alpha env flag to opt out artifact tracking annotations #1032

Merged
merged 2 commits into from
Aug 19, 2022

Conversation

Tomcli
Copy link
Member

@Tomcli Tomcli commented Aug 18, 2022

Which issue is resolved by this Pull Request:
Resolves #

Description of your changes:
Add alpha env flag to opt out artifact tracking annotations to further reduce Tekton yaml size for pipelines that need high throughputs without tracking.

Usage:
Enable the following env variable flag before compiling the pipeline

export DISABLE_ARTIFACT_TRACKING=true

Environment tested:

  • Python Version (use python --version):
  • Tekton Version (use tkn version):
  • Kubernetes Version (use kubectl version):
  • OS (e.g. from /etc/os-release):

Checklist:

@google-oss-prow google-oss-prow bot added size/M and removed size/XS labels Aug 18, 2022
@Tomcli
Copy link
Member Author

Tomcli commented Aug 18, 2022

/assign @yhwang

Copy link
Member

@yhwang yhwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Aug 19, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Tomcli, yhwang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 5f2e4a3 into kubeflow:master Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants