Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recurring runs do not inherit Pipeline Run names and substitutions #1343

Closed
HumairAK opened this issue Sep 7, 2023 · 0 comments · Fixed by #1344
Closed

Recurring runs do not inherit Pipeline Run names and substitutions #1343

HumairAK opened this issue Sep 7, 2023 · 0 comments · Fixed by #1344
Labels

Comments

@HumairAK
Copy link
Contributor

HumairAK commented Sep 7, 2023

/kind bug

What steps did you take and what happened:
It seems like scheduled runs, unlike manual runs, are not seeing proper substitutions of the pipeline name, and instead end up with the raw $ORIG_PR_NAME:

Example:
On the left is a manually triggered run, on the right is the scheduled run:
image

Furthermore this downward api ref in scheduled runs ends up doing nothing: https://github.com/kubeflow/kfp-tekton/blob/master/sdk/python/kfp_tekton/compiler/_data_passing_rewriter.py#L826, because the annotation from which it is referencing also does not get created.

What did you expect to happen:
All instances of ORIG_PR_NAME are properly substituted for the PR name, just like for manually triggered runs.

Additional information:
We are also using this attribute to work around: #1292
by identifying the locations of all the artifacts within the step copy artifact step, this unfortunately doesn't work if this variable is not properly substituted in a recurring run.

Environment:

  • SDK Version: 1.5
  • Tekton Version (use tkn version): 0.47
  • Kubernetes Version (use kubectl version): 1.26
  • OS (e.g. from /etc/os-release): fedora 37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant