-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine API #74
Refine API #74
Conversation
🎉 Thanks for your contribution It is a little monolithic, I will reivew it ASAP |
/assign @gaocegege @ddysher |
Generally LGTM, I will have a try on it. BTW, @ddysher had a talk on KubeCon and I think he may have no time these days. |
@gaocegege Thank you! |
Hi @YujiOshima ddysher may be busy, I think. And we could merge it and go ahead if you think it blocks your work. |
@gaocegege Thanks. Yes, This block some work. |
👌 |
I update
@gaocegege PTAL |
Cool I will take a look. |
/retest |
1 similar comment
/retest |
Is the test working? 🤔 |
@gaocegege @jlewi I'm not sure why the test goes time-out. Do you have any ideas? |
Thanks! Generally LGTM 👍 |
/retest |
1 similar comment
/retest |
Signed-off-by: YujiOshima <[email protected]>
Signed-off-by: YujiOshima <[email protected]>
Signed-off-by: YujiOshima <[email protected]>
Signed-off-by: YujiOshima <[email protected]>
Signed-off-by: YujiOshima <[email protected]>
Signed-off-by: YujiOshima <[email protected]>
Signed-off-by: YujiOshima <[email protected]>
Signed-off-by: YujiOshima <[email protected]>
Signed-off-by: YujiOshima <[email protected]>
Signed-off-by: YujiOshima <[email protected]>
Signed-off-by: YujiOshima <[email protected]>
Signed-off-by: YujiOshima <[email protected]>
Signed-off-by: YujiOshima <[email protected]>
Signed-off-by: YujiOshima <[email protected]>
Signed-off-by: YujiOshima <[email protected]>
/lgtm |
Is it ready to merge? |
Yes, we can merge this! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related #72 #66 #68
HyperBand and Bayes optimization suggestion are not supported in this PR.
Random and Grid Support for now.
@gaocegege
@ddysher
Signed-off-by: YujiOshima [email protected]