Cobra cli #69
Cobra cli #69
Conversation
Signed-off-by: YujiOshima <[email protected]>
Signed-off-by: YujiOshima <[email protected]>
|
Fix #54 |
cmd/cli/create.go
Outdated
| "github.com/spf13/cobra" | ||
| ) | ||
|
|
||
| //NewCommandGet generate run cmd |
There was a problem hiding this comment.
The function name is NewCommandCreate. Maybe there is a typo
cmd/cli/push.go
Outdated
| "github.com/spf13/cobra" | ||
| ) | ||
|
|
||
| //NewCommandGet generate run cmd |
|
@gaocegege Thank you! |
cmd/cli/get-model.go
Outdated
| var sInfo []*api.StudyInfo | ||
| for _, si := range r.StudyInfos { | ||
| if len(opt.args) > 0 { | ||
| if utf8.RuneCountInString(opt.args[0]) >= 7 { |
There was a problem hiding this comment.
Could we add some comments here? I can not understand the code well.
cmd/cli/get.go
Outdated
| cmd.AddCommand(NewCommandGetStudies()) | ||
| cmd.AddCommand(NewCommandGetStudy()) | ||
| // cmd.AddCommand(NewCommandGetTrials()) | ||
| // cmd.AddCommand(NewCommandGetTrial()) |
There was a problem hiding this comment.
I am wondering if we could enable the two command. WDYT
There was a problem hiding this comment.
Unfortunately, we don't have the get trial API in katib-manager.
I will refactor API and add low-level APIs (related #66 ). Then I will enable these commands.
There was a problem hiding this comment.
SGTM, I misunderstand the comments.
| fmt.Println(err) | ||
| os.Exit(1) | ||
| } | ||
|
|
cmd/cli/push-model.go
Outdated
| args []string | ||
| } | ||
|
|
||
| //NewCommandGetStudy generate run cmd |
There was a problem hiding this comment.
Please update or remove the comment here.
Signed-off-by: YujiOshima <[email protected]>
cmd/cli/get.go
Outdated
| cmd.AddCommand(NewCommandGetStudies()) | ||
| cmd.AddCommand(NewCommandGetStudy()) | ||
| // cmd.AddCommand(NewCommandGetTrials()) | ||
| // cmd.AddCommand(NewCommandGetTrial()) |
There was a problem hiding this comment.
SGTM, I misunderstand the comments.
Signed-off-by: YujiOshima <[email protected]>
Signed-off-by: YujiOshima <[email protected]>
|
@gaocegege At last, it passed the CI! |
|
/lgtm 🎉 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Introduce
spf13/cobrato katib-cli.CLI schema is drastically changed.
/assign @gaocegege