Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Refactor the structure #65

Merged
merged 12 commits into from
Apr 22, 2018
Merged

*: Refactor the structure #65

merged 12 commits into from
Apr 22, 2018

Conversation

gaocegege
Copy link
Member

Signed-off-by: Ce Gao [email protected]

Signed-off-by: Ce Gao <[email protected]>
@gaocegege
Copy link
Member Author

/hold

Signed-off-by: Ce Gao <[email protected]>
@gaocegege gaocegege changed the title *: Refactor the structure (WIP) *: Refactor the structure Apr 20, 2018
@gaocegege
Copy link
Member Author

.
├── cmd
│   ├── cli
│   ├── earlystopping
│   │   └── medianstopping
│   ├── manager
│   └── suggestion
│       ├── bayesianoptimization
│       ├── grid
│       ├── hyperband
│       └── random
├── dlk
│   ├── dlkctl
│   │   └── utils
│   └── dlkmanager
│       ├── api
│       ├── configs
│       └── datastore
├── docs
├── examples
├── manifests
├── modeldb
├── pkg
│   ├── api
│   │   └── python
│   ├── db
│   │   └── test
│   ├── earlystopping
│   ├── manager
│   │   ├── modelstore
│   │   │   └── modeldb
│   │   │       └── model_d_b_service-remote
│   │   ├── visualise
│   │   │   └── tensorboard
│   │   │       └── manifest_template
│   │   └── worker_interface
│   │       ├── dlk
│   │       ├── kubernetes
│   │       └── nvdocker
│   ├── mock
│   │   ├── api
│   │   ├── db
│   │   ├── modelstore
│   │   └── worker
│   └── suggestion
│       ├── bayesianoptimization
│       │   └── src
│       │       ├── acquisition_func
│       │       ├── global_optimizer
│       │       ├── model
├── scripts
└── test

Does it work for you? @ddysher ?

I did not refactor dlk since we have an issue to migrate it into the worker_interface #66

@gaocegege
Copy link
Member Author

/assign @YujiOshima @ddysher

I prefer to merge it after CI works. But it is time to review now.

scripts/build.sh Outdated
SCRIPT_ROOT=$(dirname ${BASH_SOURCE})/..

cd ${SCRIPT_ROOT}
# docker build -t ${PREFIX}/vizier-core -f ${CMD_PREFIX}/manager/Dockerfile .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why you commented out suggestions?
And please add Bayesian optimization suggestion build.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for test, sorry for it. OK

@YujiOshima
Copy link
Contributor

@YujiOshima
Copy link
Contributor

Please remove katib-manager binary file.

@gaocegege
Copy link
Member Author

Addressed, PTAL

@ddysher
Copy link
Member

ddysher commented Apr 21, 2018

yeah, it works. thanks!

Does it work for you? @ddysher ?

Signed-off-by: Ce Gao <[email protected]>
@gaocegege
Copy link
Member Author

/hold cancel

@YujiOshima
Copy link
Contributor

@gaocegege please look this comment #65 (comment)

@YujiOshima
Copy link
Contributor

@gaocegege Thanks!
/lgtm

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YujiOshima

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3157a7a into kubeflow:master Apr 22, 2018
@gaocegege gaocegege deleted the refactor branch April 22, 2018 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants