-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Refactor the structure #65
Conversation
Signed-off-by: Ce Gao <[email protected]>
/hold |
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
Does it work for you? @ddysher ? I did not refactor dlk since we have an issue to migrate it into the worker_interface #66 |
/assign @YujiOshima @ddysher I prefer to merge it after CI works. But it is time to review now. |
scripts/build.sh
Outdated
SCRIPT_ROOT=$(dirname ${BASH_SOURCE})/.. | ||
|
||
cd ${SCRIPT_ROOT} | ||
# docker build -t ${PREFIX}/vizier-core -f ${CMD_PREFIX}/manager/Dockerfile . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why you commented out suggestions?
And please add Bayesian optimization suggestion build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for test, sorry for it. OK
https://github.com/kubeflow/katib/pull/65/files#diff-fb322a36346f22df69b97c6f2b9d5930L24 |
Please remove katib-manager binary file. |
Addressed, PTAL |
yeah, it works. thanks!
|
Signed-off-by: Ce Gao <[email protected]>
/hold cancel |
@gaocegege please look this comment #65 (comment) |
Signed-off-by: Ce Gao <[email protected]>
@gaocegege Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: YujiOshima The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Ce Gao [email protected]