-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decoupling DB interface from katib manager #498
Conversation
Dbif adding service
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
please move |
…atib into fix_merge_conflicts
Fix merge conflicts
@achalshant thanks for your PR. I am afraid that we cannot include this feature in 0.6 release. |
Agree, we can try to take it up in the next release in June or July. |
@achalshant will you pick up this PR now? |
Okay @hougangliu . |
Syncing fork with upstream.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@achalshant: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
DB interface is introduced in #685 |
Closing this issue as the backend is pluggable |
Goal: To decouple the DB interface from katib manager in order to make the backend store pluggable. Please refer to the proposal doc for more details - https://docs.google.com/document/d/1xAi4V9SCAVZvrwiVc6a3VpK7BXPx-liQbr6YPdqBThs/edit#heading=h.1hri22e2jta
Major changes:
pkg/db/interface.go was moved to run as a service in cmd/dbif/mysql/main.go
cmd/manager/main.go is now a thin client that connects to the DBIF service using GRPC and operates on the DB.
Some services and messages from api.proto have moved to dbif.proto.
This change is