Database APIs for NAS updated #394
Conversation
Akado2009
force-pushed
the
database-api
branch
from
525123d to
cf341cc
Compare
|
/assign @YujiOshima @hougangliu @johnugeorge |
pkg/db/interface.go
Outdated
| @@ -46,8 +46,10 @@ type VizierDBInterface interface { | |||
| DBInit() | |||
| SelectOne() error | |||
|
|
|||
| GetStudyConfig(string) (*api.StudyConfig, error) | |||
| GetStudyMetrics(string) ([]string, error) | |||
There was a problem hiding this comment.
do GetStudyMetrics really need be exposed in VizierDBInterface? it seems for internal use
There was a problem hiding this comment.
I think, this is just for Select metrics from studies table.
We use it here:
Line 885 in 869fdf2
There was a problem hiding this comment.
if it's only in need in pkg/db/interface.go, you can remove line 49
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hougangliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR introduces a distinct set of API functions to save/get NAS jobs into the mysql databases. For now it creates a separate table, but after new update we're gonna use studies table, just increase the number of columns in that one. This one should be merged after: #327.
New version of #328 with squashing
This change is