Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion for Neural Architecture Search with Reinforcement Learning #339

Merged
merged 24 commits into from
Feb 21, 2019
Merged

Suggestion for Neural Architecture Search with Reinforcement Learning #339

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
a056e8b
Suggestion for Neural Architecture Search with Reinforcement Learning
Jan 23, 2019
a8709d0
Add NAS RL Suggestion
Jan 23, 2019
9342c69
Fix new line
Jan 23, 2019
86e04ce
set json format for GetSuggestion()
Jan 23, 2019
7d00c8b
finish trial return in GetSuggestion(), finish GetEvaluationHistory, …
Jan 26, 2019
bd01e67
fix a bug in GetEvaluationResult()
Jan 26, 2019
99d8761
fix bigs in GetEvaluationResult
Jan 26, 2019
8f3eee4
fix an error in GetEvaluatinResult
Jan 26, 2019
99c349c
Add python Katib api
Jan 29, 2019
758eb8a
Merge from master
Jan 29, 2019
8013ef4
Remove unnecessary requirements
Jan 29, 2019
14c77b8
add about for suggestion
Jan 29, 2019
5f7824a
rename to README
Jan 29, 2019
a476d0a
Add picture explanations; make the printouts more organized
Jan 31, 2019
2c1d374
fix typos
Feb 12, 2019
bb2c8ef
Merge remote-tracking branch 'upstream/master' into NAS-RL-suggestion
Feb 14, 2019
c535c00
fix some small problems
Feb 15, 2019
8945324
Fix several problems
Feb 19, 2019
98940c3
Fix a typo
Feb 19, 2019
b06b083
fix some problems
Feb 20, 2019
b91afe1
Merge remote-tracking branch 'upstream/master' into NAS-RL-suggestion
Feb 20, 2019
cf48a19
small fixes
Feb 20, 2019
c8c5fc6
Suggestion do not need to handle uncompleted trials
Feb 20, 2019
78b62d9
fix a small problem
Feb 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions pkg/suggestion/nasrl_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,11 +125,6 @@ def GetSuggestions(self, request, context):
time.sleep(20)
result = self.GetEvaluationResult(request.study_id)

# This lstm cell is designed to maximize the metrics
# However, if the user want to minimize the metrics, we can take the negative of the result
if self.opt_direction == api_pb2.MINIMIZE:
result = -result

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why delete above?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I made a mistake. Should delete the code above that. Already fixed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks

loss, entropy, lr, gn, bl, skip, _ = sess.run(
fetches=run_ops,
feed_dict={valid_acc: result})
Expand Down Expand Up @@ -208,8 +203,6 @@ def GetEvaluationResult(self, studyID):
return float(ml.values[-1].value)

# TODO: add support for multiple trials
self.logger.warning("Error. No trial has completed.")
return None


def _get_search_space(self, studyID):
Expand Down