Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend Katib API for NAS jobs #327
Extend Katib API for NAS jobs #327
Changes from 44 commits
89e56a3
67ce5ee
7fe9b7d
9b8764d
f6eb5ce
743265b
3e5a371
abd564e
4342a8b
f673386
fdb51d1
6edb518
de9a6d7
945d3fd
972cf30
ac63ac0
1ff6840
e8c9636
f5498e4
7c15d64
2f8dc49
7ed6b0a
9546fef
a18466e
3318467
04cdfbf
f5a5d83
a01710c
f1dac5c
d653643
2802c6f
794e7cc
4fa52ae
7ca5f0c
437b614
9db4a81
8f0d206
2324741
8766eda
c362703
4df7151
b0fb3cd
55c924e
ac2dd76
4263d1c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please explain about graphConfig and operations.
I believe The graphConfig is general information for NAS Job and Operations are task-specific info e.g. CNN.
Why not merge them? The graphConfig is able to encode to parameterconfig.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, GraphConfig is an initial general information for the Directed Acyclic Graph (DAG). We can't merge them, because for each StudyJob in NAS GraphConfig should be single and Operations can be as many as you want. Also, right now structure of Parameter config doesn't match with GraphConfig, we have to extend ParameterConfig as well in that case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/kubeflow/{{.NameSpace}}