-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing go-install-tool in the Makefile makes it easier to set up the development environment #2347
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: forsaken628 <[email protected]>
Signed-off-by: forsaken628 <[email protected]>
Signed-off-by: forsaken628 <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it. |
@forsaken628 I apologies that we don't have time to review this improvement. Are we ready to review this PR ? |
I don't think that we should take this approach. Instead of this, we should enforce the fixed version tools to $REPO_DIR/bin directory so that we can use the same version in our local. |
What this PR does / why we need it:
Current development environments use binary tools that are not isolated, which makes switching between projects troublesome and error-prone. We can improve this situation by introducing go-install-tool in the makefile.
alse see:
https://github.com/kubernetes-sigs/kubebuilder/blob/98d03bed2912b2f7adf73aeaf5f64fafa8fd927b/pkg/plugins/golang/v4/scaffolds/internal/templates/makefile.go#L263-L275
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Checklist: