Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Training operator Image in CI #2103

Merged
merged 13 commits into from
Jan 26, 2023

Conversation

johnugeorge
Copy link
Member

Update the training operator image to latest rc release - v1.6.0-rc.0

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our E2E might fail since that image has yet to be released to dockerhub.
Once that image has been pushed to dockerhub, please restart E2E.

/lgtm

@tenzen-y
Copy link
Member

tenzen-y commented Jan 26, 2023

Our E2E might fail since that image has yet to be released to dockerhub. Once that image has been pushed to dockerhub, please restart E2E.

Ah, this is my misunderstanding. The training-operator does not use an image with the release version name.

https://github.com/kubeflow/training-operator/blob/v1.6.0-rc.0/manifests/overlays/standalone/kustomization.yaml#L9

@google-oss-prow google-oss-prow bot merged commit c55414e into kubeflow:master Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants