Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate controller RBAC from kubebuilder markers #1834

Closed
wants to merge 1 commit into from

Conversation

maanur
Copy link
Contributor

@maanur maanur commented Mar 14, 2022

What this PR does / why we need it:
This PR enables automatic generation of RBAC manifests based on in-code kubebuilder markers and updates those markers to represent current API access requirements.
Access requirements declaration for each method that calls API client will make RBAC rules much more transparent.

Which issue(s) this PR fixes:
Fixes #1639

Checklist:

  • Docs included if any changes are user facing

@aws-kf-ci-bot
Copy link
Contributor

Hi @maanur. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: maanur
To complete the pull request process, please assign hougangliu after the PR has been reviewed.
You can assign the PR to them by writing /assign @hougangliu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maanur maanur changed the title Generate controller RBAC from kubebuilder marks Generate controller RBAC from kubebuilder markers Mar 14, 2022
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 74.264% when pulling 0196f00 on maanur:generate-rbac into 9c88bbc on kubeflow:master.

@maanur maanur closed this Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Narrow and explicit RBAC
3 participants