Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String type for metric values #1245

Merged
merged 4 commits into from
Jun 30, 2020
Merged

String type for metric values #1245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7e68ae6
Change metric type from float to string
andreyvelich Jun 26, 2020
cd6b37b
Check unavailable latest objective metric in isTrialObservationAvailable
andreyvelich Jun 26, 2020
1ad071b
Fix e2e test
andreyvelich Jun 27, 2020
97576ae
Delete consts.UnavailableMetricValue from e2e
andreyvelich Jun 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pkg/apis/controller/common/v1beta1/common_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,10 @@ type MetricStrategy struct {
}

type Metric struct {
Name string `json:"name,omitempty"`
Min float64 `json:"min,omitempty"`
Max float64 `json:"max,omitempty"`
Latest string `json:"latest,omitempty"`
Name string `json:"name,omitempty"`
Min string `json:"min,omitempty"`
Max string `json:"max,omitempty"`
Latest string `json:"latest,omitempty"`
}

// +k8s:deepcopy-gen=true
Expand Down
171 changes: 125 additions & 46 deletions pkg/apis/v1beta1/openapi_generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading