Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hints to obtain Kubeflow and Minikube version #1230

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

xuhdev
Copy link
Contributor

@xuhdev xuhdev commented Jun 22, 2020

Hope this helps new bug reporters

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@kubeflow-bot
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link

Hi @xuhdev. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@gaocegege
Copy link
Member

Thanks for your contribution! 🎉 👍

Please sign the CLA

@xuhdev
Copy link
Contributor Author

xuhdev commented Jun 29, 2020

Thanks @gaocegege ! Could you exempt this PR from CLA? This is a super tiny PR and signing corporate CLA has been always unsuccessful for me so far...

@gaocegege
Copy link
Member

You can choose on yourself in https://cla.developers.google.com/clas

We have to sign it before we merge the code

@xuhdev xuhdev closed this Jun 29, 2020
@xuhdev xuhdev reopened this Jun 29, 2020
@xuhdev
Copy link
Contributor Author

xuhdev commented Jun 29, 2020

@gaocegege I opened the link and it says I am covered by my IBM corporate agreements already. Could you refresh the CI to redetermine the CLA status? Thank you!

@gaocegege
Copy link
Member

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@gaocegege
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot merged commit f7cea41 into kubeflow:master Jun 30, 2020
@xuhdev xuhdev deleted the patch-1 branch June 30, 2020 03:45
sperlingxx pushed a commit to sperlingxx/katib that referenced this pull request Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants