UI: Support Trial Templates in all namespaces and all configMaps #1083
Conversation
Add FilterPannel to Trial Template View
|
I think, this PR is ready. I added Filter Panel to Trial Template View. Also, I added select boxes for Namespace and ConfigMap for creating Experiments, because it should work with new design.
Please, take a look. |
andreyvelich
changed the title
| @@ -0,0 +1,95 @@ | |||
| apiVersion: v1 | |||
There was a problem hiding this comment.
I am reluctant to have them in v1alpha3 itself as this would confuse users. What do you think?
There was a problem hiding this comment.
This change will not affect old trail template and controller.
User just can't see old Trial Templates and Submit Experiment by Parameters from the UI, using not labeled trial templates.
Other functionality in the UI will work, so they can submit Experiment using yaml file and monitor Experiments
You think that it is better not include this trial template to manifests in v1alpha3?
|
LGTM. Awesome. |
|
/retest |
|
@andreyvelich I have not seen the code/changes. So please excuse for this question. |
Do you mean specifying service account for the Trial Templates? |
|
Do you mean specifying service account for the Trial Templates? |
Yes, you can specify service account for the Trials, since it is just a Template with Job, PytorchJob, TFJob yaml. You can make these templates as you wish. |
|
/assign @johnugeorge /lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
…add-name-namespace
|
/lgtm |
…eflow#1083) * UI Support Trial Templates in all namespaces and configMaps * Change templates yaml Add FilterPannel to Trial Template View * Fix problem with adding template to empty configMap * Support Trial Templates select in Submit Experiment * Fix comments * Fix nas module name * Add version for prettier in Travis
After this PR, user can view/add/edit/delete trial templates in all namespaces and all configMaps.
Katib supports to choose any configMap for TrialTemplate, not only default template (
trial-template).Also, I changed view of Templates to looks nicer.
During this change I noticed, that it would be great if user's configMaps with TrialTemplate will be labeled, for example with label
app: katib-trial-templates.I added one example of this configMap in
manifests. Without this label it is impossible to find all configMaps with Templates for the user in the UI.In the future we can implement this feature (adding label to configMap) to the katib-controller, for example, when user submits Experiment with specific ConfigMap for trialTemplate.
Please, take a look.
/assign @johnugeorge @gaocegege @hougangliu
/cc @richardsliu
I still need to fix some small issues and test it, I marked WIP for now.
This change is