-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enhancement] Should not use Float in CRD definition. #889
Comments
/priority p3 |
We can use https://golang.org/src/encoding/json/decode.go#L187 json.Number. |
Issue Label Bot is not confident enough to auto-label this issue. |
Issue-Label Bot is automatically applying the labels:
Please mark this comment with 👍 or 👎 to give our bot feedback! |
@gaocegege Is it better than just a simple |
json.Number is a wrapper of string. We can use string, too. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
/lifecycle frozen |
/kind feature
Describe the solution you'd like
[A clear and concise description of what you want to happen.]
Ref kubernetes-sigs/controller-tools#245
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
The text was updated successfully, but these errors were encountered: