Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Upgrade CRDs to apiextensions.k8s.io/v1 #1581

Closed
gaocegege opened this issue Jul 19, 2021 · 2 comments · Fixed by #1610
Closed

[chore] Upgrade CRDs to apiextensions.k8s.io/v1 #1581

gaocegege opened this issue Jul 19, 2021 · 2 comments · Fixed by #1610
Labels

Comments

@gaocegege
Copy link
Member

/kind feature

Describe the solution you'd like
[A clear and concise description of what you want to happen.]

The api group apiextensions.k8s.io/v1beta1 is no longer served in k8s 1.22 https://kubernetes.io/docs/reference/using-api/deprecation-guide/#customresourcedefinition-v122

kubeflow APIs need to be upgraded

/cc @alculquicondor

Maybe there is problem about kubernetes/apiextensions-apiserver#50

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

@andreyvelich
Copy link
Member

@gaocegege I was able to run Experiments with this CRD and temp openAPIV3Schema:

apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
  name: experiments.kubeflow.org
spec:
  group: kubeflow.org
  scope: Namespaced
  versions:
    - name: v1beta1
      served: true
      storage: true
      additionalPrinterColumns:
        - name: Type
          type: string
          jsonPath: .status.conditions[-1:].type
        - name: Status
          type: string
          jsonPath: .status.conditions[-1:].status
        - name: Age
          type: date
          jsonPath: .metadata.creationTimestamp
      subresources:
        status: {}
      schema:
        openAPIV3Schema:
          type: object
          x-kubernetes-preserve-unknown-fields: true
  names:
    kind: Experiment
    singular: experiment
    plural: experiments
    categories:
      - all
      - kubeflow
      - katib

To generate openAPIV3Schema using controller-gen we should make some changes in APIs.
First of all, we have to remove float from our CRDs APIs(https://github.com/kubeflow/katib/blob/master/pkg/apis/controller/common/v1beta1/common_types.go#L100).
Ref issue: #889.

@gaocegege @johnugeorge Do we want to switch our CRDs to apiextensions.k8s.io/v1 at least ?

@gaocegege
Copy link
Member Author

apiextensions.k8s.io/v1beta1 is deprecated, thus I think we should do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants