Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytorchjob and Tfjob labels changed #746

Closed
hougangliu opened this issue Sep 5, 2019 · 6 comments
Closed

pytorchjob and Tfjob labels changed #746

hougangliu opened this issue Sep 5, 2019 · 6 comments

Comments

@hougangliu
Copy link
Member

kubeflow/training-operator#1064
kubeflow/pytorch-operator#204

Above PRs update pytorchjob and tfjob pod labels, and now katib depends on these labels. For backward compatibility, now katib support both the old and new version of labels.

In future, when pytorchjob and Tfjob repo drops the old one, we should update katib related code, too.

@gaocegege
Copy link
Member

Should we fix it before 0.7? @johnugeorge @hougangliu

@johnugeorge
Copy link
Member

In this release, katib will use older labels while job operators supports both(old and new) labels.

Post 0.7 release, katib should use newer labels. We can keep this PR open to track this.

@gaocegege
Copy link
Member

SGTM

@andreyvelich
Copy link
Member

@gaocegege
Copy link
Member

/close

@k8s-ci-robot
Copy link

@gaocegege: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants