-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pytorchjob and Tfjob labels changed #746
Comments
Should we fix it before 0.7? @johnugeorge @hougangliu |
In this release, katib will use older labels while job operators supports both(old and new) labels. Post 0.7 release, katib should use newer labels. We can keep this PR open to track this. |
SGTM |
@johnugeorge @gaocegege Should we close this, I think we have new labels: https://github.com/kubeflow/katib/blob/master/pkg/common/v1alpha3/common.go#L22? |
/close |
@gaocegege: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
kubeflow/training-operator#1064
kubeflow/pytorch-operator#204
Above PRs update pytorchjob and tfjob pod labels, and now katib depends on these labels. For backward compatibility, now katib support both the old and new version of labels.
In future, when pytorchjob and Tfjob repo drops the old one, we should update katib related code, too.
The text was updated successfully, but these errors were encountered: