-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Add test code for each algorithms #42
Comments
Does it mean adding unit test, like grid_service_test.go, in https://github.com/kubeflow/katib/tree/master/pkg/suggestion? |
/area 0.4.0 |
Should we split this issue up into multiple issues? |
@jlewi @YujiOshima is someone already doing this, or I should start working on this? |
@garganubhav Thanks. My colleague is working on random, grid, and hyperband. |
@garganubhav @YujiOshima per my comment above can we file individual issues for adding tests for specific algorithms and assign them to individual owners? |
@jlewi ok. I will file for Bayesian opt algorithm and work on it. |
@garganubhav any progress? Did you open up an issue for Bayesian optimization? |
yes, working on it |
@garganubhav Any update on this? What is the remaining work? Do we have an estimate for when it will be completed? Should we move this issue to 0.5 at this point? |
@garganubhav @johnugeorge @YujiOshima @gaocegege What's the current status of this issue? It looks like there is #230 for a test for bayesian optimization. Can we close out this issue since that issue exists? /cc @richardsliu |
We do not have sufficient test coverage for algos, IMO. And it is hard to import tools to show the coverage since we allow different languages to write suggestions. |
Can we close this now #406 is merged? What is the status of the e2e tests of the algorithms that use https://github.com/kubeflow/katib/blob/master/test/e2e/test-client.go. |
@johnugeorge: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There is no test code for each suggestion and early stop algorithms.
We need to test the algorithms will work as expected.
The text was updated successfully, but these errors were encountered: