Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify name style of api/studyjob field whose type is array in v1alpha2 API version #371

Closed
hougangliu opened this issue Feb 12, 2019 · 2 comments

Comments

@hougangliu
Copy link
Member

now we have some API/filed whose type is array, some of them are named with plural type and some are named with List-suffix (such as below). I think we should name them with same style in v1alpha2 API.

rpc GetStudyList(GetStudyListRequest) returns (GetStudyListReply)
rpc GetTrials(GetTrialsRequest) returns (GetTrialsReply)

type StudyJobStatus struct {
...
Trials []TrialSet json:"trials,omitempty"
...
}
type TrialSet struct {
TrialID string json:"trialid,omitempty"
WorkerList []WorkerCondition json:"workeridlist,omitempty"
}

@hougangliu hougangliu changed the title unify api/studyjob field whose type is array in v1alpha2 API version unify name style of api/studyjob field whose type is array in v1alpha2 API version Feb 12, 2019
@johnugeorge
Copy link
Member

Closing this issue. Implementation is tracked in #370

/close

@k8s-ci-robot
Copy link

@johnugeorge: Closing this issue.

In response to this:

Closing this issue. Implementation is tracked in #370

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants