You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
now we have some API/filed whose type is array, some of them are named with plural type and some are named with List-suffix (such as below). I think we should name them with same style in v1alpha2 API.
hougangliu
changed the title
unify api/studyjob field whose type is array in v1alpha2 API version
unify name style of api/studyjob field whose type is array in v1alpha2 API version
Feb 12, 2019
Closing this issue. Implementation is tracked in #370
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
now we have some API/filed whose type is array, some of them are named with plural type and some are named with List-suffix (such as below). I think we should name them with same style in v1alpha2 API.
rpc GetStudyList(GetStudyListRequest) returns (GetStudyListReply)
rpc GetTrials(GetTrialsRequest) returns (GetTrialsReply)
type StudyJobStatus struct {
...
Trials []TrialSet
json:"trials,omitempty"
...
}
type TrialSet struct {
TrialID string
json:"trialid,omitempty"
WorkerList []WorkerCondition
json:"workeridlist,omitempty"
}
The text was updated successfully, but these errors were encountered: