Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Katib job status should contain all conditions, not just the latest one #344

Closed
richardsliu opened this issue Jan 24, 2019 · 5 comments
Closed

Comments

@richardsliu
Copy link
Contributor

Current katib job status: https://github.com/kubeflow/katib/blob/master/pkg/api/operators/apis/studyjob/v1alpha1/studyjob_types.go#L60

Compare that with TFJob status, which has more details such as Reason and Message:
https://github.com/kubeflow/tf-operator/blob/master/pkg/apis/common/v1beta1/common_types.go#L83

We should consider using the latter model in the next version of the API.

@YujiOshima
Copy link
Contributor

Should we use Events field of Studyjob?

@johnugeorge
Copy link
Member

@YujiOshima Yes. Adding events will be also helpful to users like in TFJob

@johnugeorge
Copy link
Member

/assign

@richardsliu
Copy link
Contributor Author

We can close this one since the design for v1alpha2 API covers this. Implementation will be completed in 0.6.

/close

@k8s-ci-robot
Copy link

@richardsliu: Closing this issue.

In response to this:

We can close this one since the design for v1alpha2 API covers this. Implementation will be completed in 0.6.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants