Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

studyJob controller is blocked by bad CR manifests #314

Closed
hougangliu opened this issue Jan 3, 2019 · 4 comments
Closed

studyJob controller is blocked by bad CR manifests #314

hougangliu opened this issue Jan 3, 2019 · 4 comments

Comments

@hougangliu
Copy link
Member

refer to same root cause . we can follow the recommendation in this comment

ERROR: logging before flag.Parse: E0103 11:58:27.704970       1 streamwatcher.go:109] Unable to decode an event from the watch stream: unable to decode watch event: v1alpha1.StudyJob.Spec: v1alpha1.StudyJobSpec.RequestCount: readUint64: unexpected character: �, error found in #10 byte of ...|stcount":"l","studyN|..., bigger context ...|","parametertype":"categorical"}],"requestcount":"l","studyName":"random-example","suggestionSpec":{|...
ERROR: logging before flag.Parse: E0103 11:58:27.713261       1 streamwatcher.go:109] Unable to decode an event from the watch stream: unable to decode watch event: v1alpha1.StudyJob.Spec: v1alpha1.StudyJobSpec.RequestCount: readUint64: unexpected character: �, error found in #10 byte of ...|stcount":"l","studyN|..., bigger context ...|","parametertype":"categorical"}],"requestcount":"l","studyName":"random-example","suggestionSpec":{|...
ERROR: logging before flag.Parse: W0103 11:58:27.713500       1 reflector.go:341] github.com/kubeflow/katib/vendor/sigs.k8s.io/controller-runtime/pkg/cache/internal/informers_map.go:106: watch of *v1alpha1.StudyJob ended with: very short watch: github.com/kubeflow/katib/vendor/sigs.k8s.io/controller-runtime/pkg/cache/internal/informers_map.go:106: Unexpected watch close - watch lasted less than a second and no items received
ERROR: logging before flag.Parse: E0103 11:58:28.716347       1 reflector.go:205] github.com/kubeflow/katib/vendor/sigs.k8s.io/controller-runtime/pkg/cache/internal/informers_map.go:106: Failed to list *v1alpha1.StudyJob: v1alpha1.StudyJobList.Items: []v1alpha1.StudyJob: v1alpha1.StudyJob.Spec: v1alpha1.StudyJobSpec.RequestCount: readUint64: unexpected character: �, error found in #10 byte of ...|stcount":"l","studyN|..., bigger context ...|","parametertype":"categorical"}],"requestcount":"l","studyName":"random-example","suggestionSpec":{|...
ERROR: logging before flag.Parse: E0103 11:58:29.718285       1 reflector.go:205] github.com/kubeflow/katib/vendor/sigs.k8s.io/controller-runtime/pkg/cache/internal/informers_map.go:106: Failed to list *v1alpha1.StudyJob: v1alpha1.StudyJobList.Items: []v1alpha1.StudyJob: v1alpha1.StudyJob.Spec: v1alpha1.StudyJobSpec.RequestCount: readUint64: unexpected character: �, error found in #10 byte of ...|stcount":"l","studyN|..., bigger context ...|","parametertype":"categorical"}],"requestcount":"l","studyName":"random-example","suggestionSpec":{|...
@johnugeorge
Copy link
Member

Job Operators have solved it using unstructured implementation

@hougangliu
Copy link
Member Author

Job Operators have solved it using unstructured implementation

@johnugeorge do you mean this PR for tfjob?
Katib should follow this PR to fix this issue.

@johnugeorge
Copy link
Member

Yes. However, katib uses controller-runtime for controller implementation. Need to see how can it be adapted.

@gaocegege Thoughts?

@hougangliu
Copy link
Member Author

/assign

k8s-ci-robot pushed a commit that referenced this issue Feb 20, 2019
* add validating webhook for studyJob

If create/update a studyJob with bad CR manifest or invalid configuration, k8s api
server will reject the request.
Fixes: #314

* add test

* allow check "kubectl" error code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants