String type for metric values (#1245)

* Change metric type from float to string * Check unavailable latest objective metric in isTrialObservationAvailable * Fix e2e test * Delete consts.UnavailableMetricValue from e2e
kubeflow · Jun 30, 2020 · 29b797c · 29b797c
1 parent f7cea41
commit 29b797c
Show file tree

Hide file tree

Showing 11 changed files with 337 additions and 137 deletions.
diff --git a/pkg/apis/controller/common/v1beta1/common_types.go b/pkg/apis/controller/common/v1beta1/common_types.go
@@ -83,10 +83,10 @@ type MetricStrategy struct {
 }
 
 type Metric struct {
-	Name   string  `json:"name,omitempty"`
-	Min    float64 `json:"min,omitempty"`
-	Max    float64 `json:"max,omitempty"`
-	Latest string  `json:"latest,omitempty"`
+	Name   string `json:"name,omitempty"`
+	Min    string `json:"min,omitempty"`
+	Max    string `json:"max,omitempty"`
+	Latest string `json:"latest,omitempty"`
 }
 
 // +k8s:deepcopy-gen=true

diff --git a/pkg/apis/v1beta1/openapi_generated.go b/pkg/apis/v1beta1/openapi_generated.go