Revert "small fixes"

This reverts commit f4cd554.
kubeflow · Apr 23, 2019 · 217f892 · 217f892
1 parent f4cd554
commit 217f892
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 6 deletions.
diff --git a/pkg/types.go b/pkg/types.go
@@ -10,6 +10,7 @@ const (
 	VizierServiceNamespaceEnvName = "VIZIER_CORE_NAMESPACE"
 	VizierService                 = "vizier-core"
 	VizierPort                    = "6789"
+	// ManagerAddr                   = "10.111.12.89:6789"
 	ManagerAddr = VizierService + ":" + VizierPort
 )
 

diff --git a/pkg/ui/frontend/package.json b/pkg/ui/frontend/package.json
@@ -1,7 +1,6 @@
 {
   "name": "frontend",
   "version": "0.1.0",
-  "homepage": ".",
   "private": true,
   "dependencies": {
     "@babel/core": "7.2.2",

diff --git a/pkg/ui/frontend/public/index.html b/pkg/ui/frontend/public/index.html
@@ -33,7 +33,7 @@
     -->
     <style>
       body {
-        background-color: #f7f7f7;
+        background-color: #f7f7f7,
       }
     </style>
     <title>Katib UI</title>

diff --git a/pkg/ui/frontend/public/manifest.json b/pkg/ui/frontend/public/manifest.json
@@ -1,6 +1,6 @@
 {
-  "short_name": "Katib-UI",
-  "name": "Dashboard for katib",
+  "short_name": "React App",
+  "name": "Create React App Sample",
   "icons": [
     {
       "src": "favicon.ico",

diff --git a/pkg/ui/frontend/src/components/App.jsx b/pkg/ui/frontend/src/components/App.jsx
@@ -38,6 +38,10 @@ const App = (props) => {
             <Route exact path="/katib/nas_monitor" component={NASMonitor} />
             <Route path="/katib/nas_monitor/:id" component={NASJobInfo} />
             <Route path="/katib/worker" component={Worker} />
+            <Route path="/katib/collector" component={Collector} />
+            {/* <Route exact path="/" component={GenerateFromYaml} />
+            <Route path="/defaults/" component={GenerateFromParameters} />
+            <Route path="/monitor/" component={Watch} /> */}
             <Snack />
         </div>
     )

diff --git a/pkg/ui/frontend/src/components/HP/Create/YAML.jsx b/pkg/ui/frontend/src/components/HP/Create/YAML.jsx
@@ -54,7 +54,7 @@ const YAML = (props) => {
                     theme="tomorrow"
                     value={props.yaml}
                     onChange={onYamlChange}
-                    name="yaml-editor"
+                    name="UNIQUE_ID_OF_DIV"
                     editorProps={{$blockScrolling: true}}
                     tabSize={2}
                     enableLiveAutocompletion={true}

diff --git a/pkg/ui/frontend/src/components/NAS/Create/YAML.jsx b/pkg/ui/frontend/src/components/NAS/Create/YAML.jsx
@@ -55,7 +55,7 @@ const YAML = (props) => {
                     theme="tomorrow"
                     value={props.yaml}
                     onChange={onYamlChange}
-                    name="yaml-monitor"
+                    name="UNIQUE_ID_OF_DIV"
                     editorProps={{$blockScrolling: true}}
                     tabSize={2}
                     enableLiveAutocompletion={true}