Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Release Team for 1.7 #576

Merged
merged 3 commits into from
Jan 23, 2023

Conversation

DomFleischmann
Copy link
Contributor

After the Release Team being officially formed (see #kubeflow/community/issues/571). We need to update the acls with the new members and new roles.

Tagging all members in case I missed something:
@anencore94 @annajung @bradleykcardwell @chalesa101 @DnPlas @jbottum @kimwnasptd @shivaylamba @surajkota @Rishit-dagli @yubozhao

Update acls for new 1.7 Release team.
@DomFleischmann
Copy link
Contributor Author

@chensun @james-jwu

This PR has been open for quite some time, it is failing due to these PRs not being merged yet:
#579 #578

Can we address this? We will need some of these permissions to cut the 1.7 release.

@chensun
Copy link
Member

chensun commented Jan 18, 2023

@chensun @james-jwu

This PR has been open for quite some time, it is failing due to these PRs not being merged yet: #579 #578

Can we address this? We will need some of these permissions to cut the 1.7 release.

I see neither PR follows the guideline documented here: https://github.com/kubeflow/internal-acls#joining-kubeflow-github-organization
Did they ever contributed to Kubeflow before? If not, what qualifies them to join the release team, and who sponsors them?

@chensun chensun removed the request for review from neuromage January 18, 2023 10:53
@DomFleischmann
Copy link
Contributor Author

@chensun @james-jwu
This PR has been open for quite some time, it is failing due to these PRs not being merged yet: #579 #578
Can we address this? We will need some of these permissions to cut the 1.7 release.

I see neither PR follows the guideline documented here: https://github.com/kubeflow/internal-acls#joining-kubeflow-github-organization Did they ever contributed to Kubeflow before? If not, what qualifies them to join the release team, and who sponsors them?

Thanks for clarifying @chensun I can vouch for @yubozhao (#579). He is part of the BentoML team who are contributing an integration with Kubeflow and their product (see this pr). He has also been very active in the Release Team joining all the meetings.

Update release team removing members who have not signed cla agreement
@DomFleischmann
Copy link
Contributor Author

@chensun I have removed the members who are still not in the org as we need to start cutting the release in 2 days. Can this be reviewed now?

Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun, DomFleischmann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit c3e6a7a into kubeflow:master Jan 23, 2023
@DomFleischmann
Copy link
Contributor Author

Hey, @chensun it seems like I still don't have permission. Are there any further steps required?

@chensun
Copy link
Member

chensun commented Jan 26, 2023

Hey, @chensun it seems like I still don't have permission. Are there any further steps required?

Sync is broken, I'll try investigating the issue today.

@DomFleischmann
Copy link
Contributor Author

Thank you @chensun for looking into this!

@DomFleischmann
Copy link
Contributor Author

DomFleischmann commented Jan 27, 2023

@chensun Could you create a v1.7-branch branch in the kubeflow/kubeflow repository? Not being able to creat this branch is currently blocking us.

@chensun
Copy link
Member

chensun commented Jan 27, 2023

@DomFleischmann Created https://github.com/kubeflow/kubeflow/tree/v1.7-branch

I looked into the sync issue yesterday, but haven't found a solution yet. I'll post details in the issue and keep digging into it.

@jbottum
Copy link
Contributor

jbottum commented Jan 27, 2023

@theadactyl @james-jwu @chensun is there an update on this issue. We are trying to move the 1.7 RC forward and I understand this is a blocking issue.

@chensun
Copy link
Member

chensun commented Jan 27, 2023

@jbottum I created the branch requested, and I think release team should have been temporarily unblocked? Let me know if there's any other action you may need help due to permission issues.
Meanwhile, I'm still looking into the broken sync issue, I'll update progress on #587.

@jbottum
Copy link
Contributor

jbottum commented Jan 27, 2023

@chensun thank you @DomFleischmann are you unblocked ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants