Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cheimu to Kubeflow Member List #541

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

cheimu
Copy link
Member

@cheimu cheimu commented Mar 24, 2022

Provide 2-3 links to PRs or other contributions
kubeflow/training-operator#1554
kubeflow/training-operator#1556
kubeflow/training-operator#1557
kubeflow/training-operator#1558
kubeflow/training-operator#1562
kubeflow/training-operator#1564

List 2 existing members who are sponsoring your membership
@gaocegege @zw0610 Thank you!

Test your PR by running the following and Include the output in the PR.

=========================================================================== test session starts ============================================================================
platform darwin -- Python 3.8.8, pytest-6.2.4, py-1.10.0, pluggy-0.13.1
rootdir: /Users/cheimu/go/src/github.com/cheimu/internal-acls/github-orgs
plugins: anyio-3.3.2
collected 1 item                                                                                                                                                           

test_org_yaml.py .                                                                                                                                                   [100%]

============================================================================ 1 passed in 0.24s =============================================================================

@google-oss-prow
Copy link

Hi @cheimu. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cheimu
Copy link
Member Author

cheimu commented Mar 24, 2022

/assign @zijianjoy

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 🎉 👍

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/ok-to-test

@zw0610
Copy link
Member

zw0610 commented Mar 24, 2022

/lgtm

@zw0610 zw0610 removed their assignment Mar 25, 2022
@cheimu
Copy link
Member Author

cheimu commented Mar 25, 2022

/assign @chensun

@chensun
Copy link
Member

chensun commented Mar 25, 2022

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheimu, chensun, gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 289a115 into kubeflow:master Mar 25, 2022
zijianjoy pushed a commit to zijianjoy/internal-acls that referenced this pull request Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants