[WIP] Make fairing work with JupyterHub #7
Conversation
skeleton for serving
Refactor strategies/architectures
Update README
Add namespace support
| shutil.copytree(context_dir, dst) | ||
|
|
||
| def get_mount_point(self): | ||
| return os.path.join(os.environ['HOME'], '.fairing/build-contexts/') | ||
| #return os.path.join('/tmp/fairing/build-contexts/') |
|
|
||
| success = self.check_build_succeeded(bld) | ||
| if success: | ||
| logger.error('Build finished successfully.') | ||
| logger.warn('Build finished successfully.') |
There was a problem hiding this comment.
why is this message warn if the build was successful?
There was a problem hiding this comment.
So that users get a confirmation either in the console or in the notebook that their job was launched without having to change the verbosity of the logger.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: r2d4 If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This should look a lot cleaner on github if you rebase on the current master branch right? |
|
@r2d4 I actually can't rebase since we squashed the initial PR. So I would need to go over the changes of each commits. However, I am still not sure if we need this PR or not. |
|
@wbuchwalter @r2d4 Any update on this PR? Can we close it? Or do we still need it? |
|
@jlewi Closing it. the new append builder works fine from JH so it's the recommended way to do that. |
This is an attempt to bypass the various limitations introduced by JupyterHub.
@jlewi @r2d4 Is there already a timeline for when Kubeflow will migrate from JupyterHub to the custom notebook controller?
If yes, Is this PR even needed?
Note: The history is a bit weird because kubeflow/fairing is not a fork of wbuchwalter/fairing, but we can just squash everything.
Fixes #6
This change is