Skip to content
This repository has been archived by the owner on Aug 17, 2023. It is now read-only.

Adding more optional parameters #52

Closed
wants to merge 1 commit into from

Conversation

hamedhsn
Copy link
Contributor

@hamedhsn hamedhsn commented Jan 10, 2019

Provide a capability to pass a few options when running job

  • job_name
  • image_pull_policy
  • restart_policy

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: r2d4

If they are not already assigned, you can assign the PR to them by writing /assign @r2d4 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @hamedhsn. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wbuchwalter
Copy link
Contributor

Do we really want this to be controlled at the user level?
Fairing shouldn't expose all possible parameters that are available on the pod/job spec.
Could this be just solved by sane default in the builder?
If there is really a need for customization, could this be solved with the admin config (#28) instead?

@hamedhsn
Copy link
Contributor Author

hmm.. I see.
configmap make sense for really admin stuff like image_pull_policy or restart policy, however, users might want to pick the name for their jobs. This will make it easier once multiple users submit different jobs. Based on my observation, in most of the case names are chosen meaningful to the experiments.
Any further operations make it easier once it has a custom name.

@jlewi
Copy link
Contributor

jlewi commented Jan 12, 2019

/assign @r2d4
/unassign @richardsliu

@hamedhsn
Copy link
Contributor Author

hamedhsn commented Mar 5, 2019

closing this as it is old and was before major refactoring.

@hamedhsn hamedhsn closed this Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants