-
Notifications
You must be signed in to change notification settings - Fork 143
Work around k8s client issue to avoid blocking CI tests #422
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/retest |
The current change to not install a pre-release version of the kubernetes python client is a robust fix, but also hard coding the fix for this version and for that PyPI package specifically. Note that pip won't install pre-releases, but I created the following alternative PR: #423 |
@consideRatio Great thanks for the comments, totally agree with you, we install Kubeflow fairing using /test kubeflow-fairing-presubmit |
Seems the CI tests caused by env problem?
|
/test kubeflow-fairing-presubmit |
/retest |
@jinchihe: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What this PR does / why we need it:
Work around k8s client issue to avoid blocking CI tests
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #421
Special notes for your reviewer:
Release note:
This change is