Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update join Slack link to the non expiring link #604

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Update join Slack link to the non expiring link #604

merged 1 commit into from
Feb 1, 2023

Conversation

mameshini
Copy link
Contributor

No description provided.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mameshini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link

@mameshini: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jbottum
Copy link
Contributor

jbottum commented Feb 1, 2023

/lgtm

thanks!

@google-oss-prow google-oss-prow bot added the lgtm label Feb 1, 2023
@google-oss-prow google-oss-prow bot merged commit 71a5026 into kubeflow:master Feb 1, 2023
@mameshini mameshini deleted the im-patch-1 branch February 1, 2023 19:26
@thesuperzapper
Copy link
Member

@mameshini @jbottum can we please update it to https://www.kubeflow.org/docs/about/community/#kubeflow-slack (rather than using the invited link directly).

As I was saying in #602 (comment), if we change how we do Slack inviting in the future, we will forget about this link otherwise.

@Syulin7
Copy link
Contributor

Syulin7 commented Feb 2, 2023

@mameshini @jbottum can we please update it to https://www.kubeflow.org/docs/about/community/#kubeflow-slack (rather than using the invited link directly).

As I was saying in #602 (comment), if we change how we do Slack inviting in the future, we will forget about this link otherwise.

Agree. I would like to update it.

@mameshini
Copy link
Contributor Author

Updated and merged [#605] into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants