wg-manifests: Introduce WG Manifests #435
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,7 +19,7 @@ The WG covers researching, developing and operating various targets of ML automa | |
| #### Cross-cutting and Externally Facing Processes | ||
|
|
||
| - Coordinating with Training WG to make sure that all distributed training jobs can be used in AutoML experiments. | ||
| - Coordinating with Manifests WG to ensure that AutoML manifests are properly deployed with Kubeflow. | ||
|
There was a problem hiding this comment.
Why would this be necessary? There was a problem hiding this comment.
@jlewi those are not new scopes, but pre-existing ones. |
||
| - Coordinating with Central Dashboard WG to correct integration with AutoML UI. | ||
| - Coordinating with release teams to ensure that the AutoML features can be released properly. | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| <!--- | ||
| This is an autogenerated file! | ||
|
|
||
| Please do not edit this file directly, but instead make changes to the | ||
| sigs.yaml file in the project root. | ||
|
|
||
| To understand how this file is generated, see https://github.com/kubeflow/community/generator/README.md | ||
| ---> | ||
| # Manifests Working Group | ||
|
|
||
| WG Manifests maintains a centralized repository of manifests. | ||
|
|
||
| The [charter](charter.md) defines the scope and governance of the Manifests Working Group. | ||
|
|
||
| ## Meetings | ||
| * Regular WG Meeting (Pacific AM): [Tuesdays at 08:00 PT (Pacific Time)]() (biweekly - every other Tuesday). [Convert to your timezone](http://www.thetimezoneconverter.com/?t=08:00&tz=PT%20%28Pacific%20Time%29). | ||
| * [Meeting notes and Agenda](http://bit.ly/kf-meeting-notes). | ||
|
|
||
| ## Organizers | ||
|
|
||
| * Yao Xiao (**[@PatrickXYS](https://github.com/PatrickXYS)**), AWS | ||
| * Vangelis Koukis (**[@vkoukis](https://github.com/vkoukis)**), Arrikto | ||
| * Yannis Zarkadas (**[@yanniszark](https://github.com/yanniszark)**), Arrikto | ||
|
|
||
| ## Contact | ||
| - Slack: [#wg-manifests](https://kubeflow.slack.com/messages/wg-manifests) | ||
| - [Mailing list](https://groups.google.com/forum/#!forum/kubeflow-discuss) | ||
| - [Open Community Issues/PRs](https://github.com/kubeflow/community/labels/wg%2Farea/wg-manifests) | ||
| - GitHub Teams: | ||
| - [@kubeflow/wg-manifests-bugs](https://github.com/orgs/kubeflow/teams/wg-manifests-bugs) - Bug Triage and Troubleshooting | ||
| - [@kubeflow/wg-manifests-misc](https://github.com/orgs/kubeflow/teams/wg-manifests-misc) - General Discussion | ||
| - [@kubeflow/wg-manifests-reviews](https://github.com/orgs/kubeflow/teams/wg-manifests-reviews) - Changes and Reviews | ||
| <!-- BEGIN CUSTOM CONTENT --> | ||
|
|
||
| <!-- END CUSTOM CONTENT --> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| # WG Manifests Charter | ||
|
|
||
| This charter adheres to the conventions, roles and organization management | ||
| outlined in [wg-governance]. | ||
|
|
||
| ## Scope | ||
|
|
||
| - Provide a catalog (centralized repository) of Kubeflow application manifests. | ||
|
There was a problem hiding this comment. Trying to understand wg-manifests will help maintain existing manifest or start a new manifest project for next generation. There was a problem hiding this comment. We won't maintain the current manifests. We will structure new manifests based on the principles laid in this PR. The same manifests repo will be used. There was a problem hiding this comment. @Jeffwan if you are asking this due to kfctl, I think there are two options we can explore together:
There was a problem hiding this comment.
@yanniszark who is maintaining the manifests you or the application owners? My expectation is that this repo is just a mirror of whatever is upstream e.g. /pipelines = https://github.com/kubeflow/pipelines/tree/master/manifests It looks like for the other applications they may not have upstream manifests yet. So my expectation is that this WG is
Does that match your understanding? There was a problem hiding this comment. Yes it does. I will soon update the charter to reflect that. |
||
| - Provide a catalog of third-party apps for common services. | ||
|
|
||
| ### In scope | ||
|
|
||
| #### Code, Binaries and Services | ||
|
|
||
| - Maintain tooling to automate copying manifests from upstream app repos. | ||
| - Maintain a catalog that will allow users to install Kubeflow apps and | ||
| common services easily on Kubernetes, either on the cloud or on-prem, without | ||
| depending on external cloud services or closed source solutions. Those | ||
| manifests are deployed using `kubectl` and `kustomize` and include: | ||
| 1. A common set of manifests for the current official Kubeflow applications: | ||
| - Training Operators | ||
| - Kubeflow Pipelines (KFP) | ||
| - Notebooks | ||
| - KFServing | ||
| - Katib | ||
| - Central Dashboard | ||
| - Profile Controller | ||
| - PodDefaults Controller | ||
| 1. Manifests for a set of specific common services: | ||
| - Istio | ||
| - KNative | ||
| - Dex | ||
| - Cert-Manager | ||
|
|
||
| #### Cross-cutting and Externally Facing Processes | ||
|
|
||
| ##### With Application Owners | ||
|
|
||
| - Aid applications owners in creating kustomize manifests for their application, | ||
| inside the app repo, if those don't exist already. | ||
| - Communicate with application owners to agree upon the version they want to be | ||
|
There was a problem hiding this comment. I think this part, should we include PM team as well, since we rely on them about cross-project conversations. There was a problem hiding this comment. @PatrickXYS I agree, but there is no PM WG right now and I don't see something similar in other WGs. |
||
| included in the next Kubeflow release. | ||
|
|
||
| ##### With Distribution Owners | ||
|
|
||
| - Coordinate with distribution owners, to make sure they are in-sync about the | ||
| release schedule and have time to test and bring their distributions | ||
| up-to-date. | ||
|
|
||
| ### Out of scope | ||
|
There was a problem hiding this comment. Please include the following in out of scope
|
||
|
|
||
yanniszark marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| This WG is NOT going to: | ||
| - Maintain deployment-specific tools like `kfctl`. | ||
| - Maintain distribution-specific manifests. | ||
| - Decide which applications to include in Kubeflow. | ||
| - Decide which variant of an application to include (e.g., KFP Standalone vs | ||
| KFP with Istio). | ||
| - Create and maintain one or more Kubeflow distributions. | ||
| - Support configurations with environment-specific requirements, like special | ||
yanniszark marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| hardware, different versions of third-party apps (e.g., Istio, KNative, etc.) | ||
| or custom OIDC providers. | ||
| - Support and promote a specific deployment tool (e.g., `kfctl`). Opinionated | ||
| deployment tools can extend the base kustomizations to create manifests that | ||
| support their methods. | ||
| - For example, people invested in `kfctl` can create overlays that enable | ||
| the use of `kfctl`'s parameter substitution, which expects a specific | ||
| folder structure (`params.env`). | ||
|
|
||
| ## Roles and Organization Management | ||
|
|
||
| This WG adheres to the Roles and Organization Management outlined in | ||
| [wg-governance] and opts-in to updates and modifications to [wg-governance]. | ||
|
|
||
| [wg-governance]: ../wg-governance.md | ||
| [wg-subprojects]: https://github.com/Kubeflow/community/blob/master/wg-YOURWG/README.md#subprojects | ||
| [Kubeflow Charter README]: https://github.com/Kubeflow/community/blob/master/committee-steering/governance/README.md | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this in scope for this WG?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think autoML covers this part. https://github.com/kubeflow/community/blame/master/wg-automl/charter.md#L21
It can be removed here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is not related to this PR, unless I am missing something.