This repository has been archived by the owner on Sep 12, 2023. It is now read-only.
Create expectation package #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Jeffwan
force-pushed
the
add_expectation
branch
from
065682a
to
9b3c679
Compare
This is too restrict.. it's pretty common to ignore output check. Disable |
|
/hold Please help on review first. I will run some real test against this version manually. |
Jeffwan
force-pushed
the
add_expectation
branch
from
9b3c679
to
bb36399
Compare
The purpose of this PR is to get ride of direct Kubernetes dependency. Expectation is being used in JobController to tell the number of pods/services they expect. This is the only library we reference in common code base. It makes sense to copy to our code base. In the future, Instead of “import k8s.io/kubernetes/pkg/controller”, User need to “import github.com/kubeflow/common/pkg/controller.v1/expectation" and use `expectation.NewControllerExpectations` instead. Signed-off-by: Jiaxin Shan <[email protected]>
Jeffwan
force-pushed
the
add_expectation
branch
from
bb36399
to
7607476
Compare
|
@gaocegege This one bring expectation back to repo. We remove all the direct dependency of Kubernetes now. |
|
Is this still on hold? |
|
/hold cancel This can be merged. @terrytangyuan |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #48. Besides #73, this is the last PR to remove direct Kubernetes dependency. I think current strategy is folk PodControlInterface and Expectations from main Kubernetes pkg and maintain in common repo. This also helps to make sure our code is reliable without worrying about changes K8s version upgrade brings.
For long term, I will try to brings these changes to
kubernetes/client-goand we can use client-go directly. Track progress here. kubernetes/client-go#332The purpose of this PR is to get ride of direct Kubernetes dependency. Expectation is being used in JobController to tell the number of pods/services they expect.
In the future, Instead of
import k8s.io/kubernetes/pkg/controller, User need toimport github.com/kubeflow/common/pkg/controller.v1/expectationand useexpectation.NewControllerExpectationsinstead.Signed-off-by: Jiaxin Shan [email protected]
/cc @gaocegege @terrytangyuan