-
Notifications
You must be signed in to change notification settings - Fork 73
Deprecate glog and move to commonutil logger #53
Conversation
1. Remove all glog references and use commonutil logger instead. 2. Create method LoggerForService in logger 3. Clean up go.mod and go.sum Signed-off-by: Jiaxin Shan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Have other operators removed the use of glog yet? If not, would this break existing 3rd party logging service by using different logging frameworks?
@terrytangyuan Tf-operator and mpi-operator still has few references. I will file follow up PRs to migrate them either to klog or logrus later. This will not break existing logging service. The situation is we have multiple logs solutions and this PR helps to use unified one across the project. (In this project, logrus) |
Fix an edge case in the test and please have another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Upgrade kaleido-models version * Add environement variable `COMPUTE_CAPABILITY` to be able to launch it locally
Address #52
Signed-off-by: Jiaxin Shan [email protected]
This change is