Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

Deprecate glog and move to commonutil logger #53

Merged
merged 2 commits into from
Mar 9, 2020

Conversation

Jeffwan
Copy link
Member

@Jeffwan Jeffwan commented Mar 8, 2020

Address #52

  1. Remove all glog references and use commonutil logger instead.
  2. Create method LoggerForService in logger
  3. Clean up go.mod and go.sum

Signed-off-by: Jiaxin Shan [email protected]


This change is Reviewable

1. Remove all glog references and use commonutil logger instead.
2. Create method LoggerForService in logger
3. Clean up go.mod and go.sum

Signed-off-by: Jiaxin Shan <[email protected]>
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Have other operators removed the use of glog yet? If not, would this break existing 3rd party logging service by using different logging frameworks?

@Jeffwan
Copy link
Member Author

Jeffwan commented Mar 9, 2020

Thanks! Have other operators removed the use of glog yet? If not, would this break existing 3rd party logging service by using different logging frameworks?

@terrytangyuan Tf-operator and mpi-operator still has few references. I will file follow up PRs to migrate them either to klog or logrus later. This will not break existing logging service. The situation is we have multiple logs solutions and this PR helps to use unified one across the project. (In this project, logrus)

@Jeffwan
Copy link
Member Author

Jeffwan commented Mar 9, 2020

Fix an edge case in the test and please have another look.

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 10f80de into kubeflow:master Mar 9, 2020
@Jeffwan Jeffwan deleted the glog_deprecation branch March 9, 2020 17:12
georgkaleido pushed a commit to georgkaleido/common that referenced this pull request Jun 9, 2022
* Upgrade kaleido-models version

* Add environement variable `COMPUTE_CAPABILITY` to be able to launch it locally
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants