Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

Unify the label keys #29

Merged
merged 1 commit into from
Apr 26, 2019
Merged

Unify the label keys #29

merged 1 commit into from
Apr 26, 2019

Conversation

jian-he
Copy link
Contributor

@jian-he jian-he commented Apr 25, 2019

Since we have a common operator, and think the common label keys can also be unified, so that the custom operator will not need to implement these


This change is Reviewable

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
This would simplify the implementation.

@johnugeorge
Copy link
Member

if same labels are used for all job operators, Will the pod label key-value collide for jobs with same name in the same namespace? (When pods are listed)

@jian-he
Copy link
Contributor Author

jian-he commented Apr 26, 2019

if same labels are used for all job operators, Will the pod label key-value collide for jobs with same name in the same namespace? (When pods are listed)

I think the pod can not be created in the first place, because the pod name needs to be unique, see how the pod name is generated

we can add a label like "job-type=tensorflow" if needed.

Today the tf-operator implementation always list all pods regardless job types and names, which I think can be improved.

@richardsliu
Copy link
Contributor

/lgtm
/approve
+1 for adding the job-type label later.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardsliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ba975e8 into kubeflow:master Apr 26, 2019
georgkaleido pushed a commit to georgkaleido/common that referenced this pull request Jun 9, 2022
* Fix BestCheckpointNameFixer

* Update image version

* Update image version
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants