This repository has been archived by the owner on Sep 12, 2023. It is now read-only.
Changing label selector type for HPA #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnugeorge
changed the title
|
/lgtm Thanks for the fix! |
|
/cc @terrytangyuan |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Jan 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per docs, https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#scale-subresource
labelSelectorPathreferred byScale.Status.Selectorneeds to be a stringThe field pointed by this JSON path must be a string field (not a complex selector struct) which contains a serialized label selector in string form.Currently, HPA creation fails because of this reason. Related (kubeflow/training-operator#1645, kubeflow/training-operator#1626)
This change needs changes in training-operator as well which will be fixed in a different PR.
/assign @gaocegege
/cc @kubeflow/wg-training-leads