Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

Rollback #172 as it introduce hard requirements for the list values to not be empty #174

Merged
merged 2 commits into from
Nov 11, 2021
Merged

Rollback #172 as it introduce hard requirements for the list values to not be empty #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88a74f0
Change listType to be map for jobstatus condition
pugangxa Nov 11, 2021
9e89b1c
rollback the changes to allow empty value for condition
pugangxa Nov 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions pkg/apis/common/v1/openapi_generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion pkg/apis/common/v1/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import (
// +k8s:deepcopy-gen=true
// JobStatus represents the current observed state of the training Job.
type JobStatus struct {
// +listType=set
// Conditions is an array of current observed job conditions.
Conditions []JobCondition `json:"conditions"`

Expand Down