-
Notifications
You must be signed in to change notification settings - Fork 71
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign @Jeffwan
@Jeffwan As tested in this pr kubeflow/training-operator#1462, the updated common library works with training-operator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR can move forward once the issue here kubeflow/training-operator#1462 is addressed. |
ping @Jeffwan @terrytangyuan as the all tested passed: kubeflow/training-operator#1462 However, please note that tf-controller is actually modified to keep up with the labels in new kubeflow/common. I submitted another pr kubeflow/training-operator#1474 to fix the label issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Since PR #163 has been stalled for a while, this pr tries to accomplish the same goal: revert rtype from
commonv1.ReplicaType
tostring
.For any parameters, if it is of type
commonv1.ReplicaType
, it's reverted tostring
in this pr. However, parameters of typemap[commonv1.ReplicaType]{any_value_type}
remain unchanged.@Jeffwan