Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

Enable GitHub action to build and test code #162

Closed
Jeffwan opened this issue Sep 19, 2021 · 9 comments
Closed

Enable GitHub action to build and test code #162

Jeffwan opened this issue Sep 19, 2021 · 9 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Jeffwan
Copy link
Member

Jeffwan commented Sep 19, 2021

See #161

#141 introduces some build failures but we don't notice that before we merge the code. Travis somehow was deleted at that time. @gaocegege suggests to use Github actions.

Let's migrate scripts https://github.com/kubeflow/common/blob/master/.travis.yml to a Github Action manner.

We do need this to guarantee code quality

/help
/good-first-issue

@google-oss-robot
Copy link

@Jeffwan:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

See #161

#141 introduces some build failures but we don't notice that before we merge the code. Travis somehow was deleted at that time. @gaocegege suggests to use Github actions.

Let's migrate scripts https://github.com/kubeflow/common/blob/master/.travis.yml to a Github Action manner.

/help
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Jeffwan
Copy link
Member Author

Jeffwan commented Sep 19, 2021

/assign @SumLare

@google-oss-robot
Copy link

@Jeffwan: GitHub didn't allow me to assign the following users: SumLare.

Note that only kubeflow members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @SumLare

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Jeffwan
Copy link
Member Author

Jeffwan commented Sep 20, 2021

https://github.com/kubeflow/common/runs/3648012266 Interesting, in the latest workflow, I didn't see failure logs..

@SumLare
Copy link
Contributor

SumLare commented Sep 20, 2021

Well https://status.coveralls.io/ still doesn't look good

@Jeffwan
Copy link
Member Author

Jeffwan commented Sep 20, 2021

Yeah, that's the problem

bad response status from coveralls: 503
<h2>This website is under heavy load (queue full)</h2><p>We're sorry, too many people are accessing this website at the same time. We're working on this problem. Please try again later.</p>

@gaocegege
Copy link
Member

coveralls crashes sometimes.

@Jeffwan
Copy link
Member Author

Jeffwan commented Sep 21, 2021

Let's do this to overcome the issue. Since goveralls is nice to have, we can ignore the failures in CI. I can not believe recovery takes that long..

goveralls || echo "push to coveralls failed"

@Jeffwan
Copy link
Member Author

Jeffwan commented Sep 24, 2021

This can be closed. thanks @SumLare !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants