feat(job): Add a check to avoid null pointer exception (#178)

Signed-off-by: Ce Gao <[email protected]>
kubeflow · Nov 26, 2021 · 1edc535 · 1edc535
1 parent 26a6cec
commit 1edc535
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/pkg/controller.v1/common/job.go b/pkg/controller.v1/common/job.go
@@ -327,7 +327,9 @@ func (jc *JobController) CleanupJob(runPolicy *apiv1.RunPolicy, jobStatus apiv1.
 		return nil
 	}
 	duration := time.Second * time.Duration(*ttl)
-	// todo: Is the jobStatus.CompletionTime maybe nil ?
+	if jobStatus.CompletionTime == nil {
+		return fmt.Errorf("job completion time is nil, cannot cleanup")
+	}
 	finishTime := jobStatus.CompletionTime
 	expireTime := finishTime.Add(duration)
 	if currentTime.After(expireTime) {