Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marshal: Save TF models under a versioned folder #228

Merged

Conversation

StefanoFioravanzo
Copy link
Member

TensorFlow serving expects a model to saved under a versioned (e.g. 1/,
2/, ...) folder, so that the user can save multiple versions of the same
mudel in the same place.

We now always save a model under 1/ just in case the dump needs to be
served as well. The function load_model does not handle this case
thouth, so we need to take it into account.

Signed-off-by: Stefano Fioravanzo [email protected]

TensorFlow serving expects a model to saved under a versioned (e.g. 1/,
2/, ...) folder, so that the user can save multiple versions of the same
mudel in the same place.

We now always save a model under `1/` just in case the dump needs to be
served as well. The function `load_model` does not handle this case
thouth, so we need to take it into account.

Signed-off-by: Stefano Fioravanzo <[email protected]>
Reviewed-by: Dimitris Poulopoulos <[email protected]>
@dpoulopoulos dpoulopoulos merged commit 720b5d2 into kubeflow-kale:master Oct 7, 2020
@StefanoFioravanzo StefanoFioravanzo deleted the feature-tf-serving-marshal branch October 7, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants