-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
panic when multiple goroutine concurrency access same map #2037
Conversation
Welcome @Yellow-L! It looks like this is your first PR to kubeedge/kubeedge 🎉 |
is it better to use sync.Map instead of manually add lock? |
@luogangyi yes, you're right, i'll change from it to sync.map. |
@Yellow-L Please fix the ci issue :) Need run make lint in your host |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fisherxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@fisherxu :) |
@Yellow-L Would you like to cherry-pick the PR to release-1.4 branch throuch |
@fisherxu yes, no problem. |
…-upstream-release-1.4 Automated cherry pick of #2037: panic when multiple goroutine concurrency access same map
What type of PR is this?
/kind bug
What type of PR is this?
What this PR does / why we need it:
panic when multiple goroutine concurrency access same map
Which issue(s) this PR fixes:
Fixes #2036
Special notes for your reviewer:
N/A