Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panic when multiple goroutine concurrency access same map #2037

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

Yellow-L
Copy link
Contributor

@Yellow-L Yellow-L commented Aug 5, 2020

What type of PR is this?

/kind bug
What type of PR is this?

What this PR does / why we need it:
panic when multiple goroutine concurrency access same map

Which issue(s) this PR fixes:
Fixes #2036

Special notes for your reviewer:
N/A

@kubeedge-bot
Copy link
Collaborator

Welcome @Yellow-L! It looks like this is your first PR to kubeedge/kubeedge 🎉

@kubeedge-bot kubeedge-bot added kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 5, 2020
@luogangyi
Copy link
Member

luogangyi commented Aug 5, 2020

is it better to use sync.Map instead of manually add lock?

@Yellow-L
Copy link
Contributor Author

Yellow-L commented Aug 6, 2020

@luogangyi yes, you're right, i'll change from it to sync.map.

@fisherxu
Copy link
Member

fisherxu commented Aug 6, 2020

@Yellow-L Please fix the ci issue :) Need run make lint in your host

@fisherxu
Copy link
Member

fisherxu commented Aug 7, 2020

/lgtm
/approve
Thanks for the fixing :)

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2020
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fisherxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2020
@kubeedge-bot kubeedge-bot merged commit 37bc0eb into kubeedge:master Aug 7, 2020
@Yellow-L
Copy link
Contributor Author

Yellow-L commented Aug 7, 2020

@fisherxu :)

@fisherxu
Copy link
Member

fisherxu commented Aug 7, 2020

@Yellow-L Would you like to cherry-pick the PR to release-1.4 branch throuch hack/cherry-pick_pull.sh script? So we can release it in 1.4.

@Yellow-L
Copy link
Contributor Author

Yellow-L commented Aug 7, 2020

@fisherxu yes, no problem.

kubeedge-bot added a commit that referenced this pull request Aug 7, 2020
…-upstream-release-1.4

Automated cherry pick of #2037: panic when multiple goroutine concurrency access same map
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic on cloudcore when too much edgenode connected
4 participants