-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix panic: concurrent write to websocket #1112
Conversation
@fisherxu: GitHub didn't allow me to request PR reviews from the following users: alien19880726. Note that only kubeedge members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @alien19880726 |
@fisherxu: GitHub didn't allow me to request PR reviews from the following users: alien19880726. Note that only kubeedge members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kevin-wangzefeng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
/kind bug
What this PR does / why we need it:
routeToCloud
andkeeplive
are two goroutines, if there's no lock here, edgecore will panic when they concurrent write to websocket connection.Which issue(s) this PR fixes:
Fixes #1017
Special notes for your reviewer:
/cc @kevin-wangzefeng @kadisi @alien19880726
Does this PR introduce a user-facing change?: